Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1418213003: Revert of Introduce LookupIterator::Restart() and use it (Closed)

Created:
5 years, 2 months ago by Michael Hablich
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Introduce LookupIterator::Restart() and use it (patchset #2 id:20001 of https://codereview.chromium.org/1416053007/ ) Reason for revert: Breaks test if rolled into Chromium: http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%281%29&number=60441 Needed so the reverts applies cleanly and seems to be related to the offending CL. Original issue's description: > Introduce LookupIterator::Restart() and use it > > Committed: https://crrev.com/5676415b4add059b78f98a9a762d00c8d721dbcd > Cr-Commit-Position: refs/heads/master@{#31483} TBR=verwaest@chromium.org,jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/984f8af8922d368755d9dd6e2537817d66ae4530 Cr-Commit-Position: refs/heads/master@{#31534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -26 lines) Patch
M src/lookup.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/lookup.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 8 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Hablich
Created Revert of Introduce LookupIterator::Restart() and use it
5 years, 2 months ago (2015-10-23 19:21:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418213003/1
5 years, 2 months ago (2015-10-23 19:21:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 19:22:00 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 19:22:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/984f8af8922d368755d9dd6e2537817d66ae4530
Cr-Commit-Position: refs/heads/master@{#31534}

Powered by Google App Engine
This is Rietveld 408576698