Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1418213002: X87: [Interpreter] Add CallRuntime support to the interpreter. (Closed)

Created:
5 years, 2 months ago by zhengxing.li
Modified:
5 years, 2 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Add CallRuntime support to the interpreter. port 75f6ad74b2c0fe2e5dec7110d076d892cfbb6b69 (r31089). original commit message: Adds support for calling runtime functions from the interpreter. Adds the CallRuntime bytecode which takes a Runtime::FunctionId of the function to call and the arguments in sequential registers. Adds a InterpreterCEntry builtin to enable the interpreter to enter C++ code based on the functionId. Also renames Builtin::PushArgsAndCall to Builtin::InterpreterPushArgsAndCall and groups all the interpreter builtins together. BUG=v8:4280 LOG=N Committed: https://crrev.com/c38e429035a98972e25f7ab358b46b302ab20199 Cr-Commit-Position: refs/heads/master@{#31502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -49 lines) Patch
M src/x87/builtins-x87.cc View 2 chunks +35 lines, -35 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +13 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 2 months ago (2015-10-23 09:04:17 UTC) #2
Weiliang
lgtm
5 years, 2 months ago (2015-10-23 09:10:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418213002/1
5 years, 2 months ago (2015-10-23 09:10:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 09:41:40 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 09:42:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c38e429035a98972e25f7ab358b46b302ab20199
Cr-Commit-Position: refs/heads/master@{#31502}

Powered by Google App Engine
This is Rietveld 408576698