Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1418193005: Push more upload arguments logic from perf_test_runner -> devtools. (Closed)

Created:
5 years, 1 month ago by ppi
Modified:
5 years, 1 month ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Push more upload arguments logic from perf_test_runner -> devtools. This patch moves the check for required arguments and inferring of revision and point_id into devtoolslib/perf_dashboard, so that it can be shared between `perf_test_runner` and `mojo_benchmark`. R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/32d6447076bec1e828295eabd1fe49ca60aa6931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -23 lines) Patch
M mojo/devtools/common/devtoolslib/perf_dashboard.py View 4 chunks +25 lines, -4 lines 0 comments Download
M mojo/tools/perf_test_runner.py View 3 chunks +4 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Etienne, ptal.
5 years, 1 month ago (2015-10-26 14:16:50 UTC) #2
etiennej
lgtm
5 years, 1 month ago (2015-10-26 16:46:00 UTC) #3
ppi
5 years, 1 month ago (2015-10-27 10:45:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
32d6447076bec1e828295eabd1fe49ca60aa6931 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698