Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1418143006: Roll instrumentation log files. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Roll instrumentation log files. Keep up to 5 old log files. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/61ee6dff5f5e8a9da1bd7b26645f8be2926a6df4

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +17 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 1 month ago (2015-11-04 21:41:39 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1418143006/diff/1/pkg/analysis_server/lib/src/server/driver.dart File pkg/analysis_server/lib/src/server/driver.dart (right): https://codereview.chromium.org/1418143006/diff/1/pkg/analysis_server/lib/src/server/driver.dart#newcode593 pkg/analysis_server/lib/src/server/driver.dart:593: new File(oldPath).renameSync('$path.${i+1}'); Does rename work if there's already ...
5 years, 1 month ago (2015-11-04 23:00:30 UTC) #2
scheglov
https://codereview.chromium.org/1418143006/diff/1/pkg/analysis_server/lib/src/server/driver.dart File pkg/analysis_server/lib/src/server/driver.dart (right): https://codereview.chromium.org/1418143006/diff/1/pkg/analysis_server/lib/src/server/driver.dart#newcode593 pkg/analysis_server/lib/src/server/driver.dart:593: new File(oldPath).renameSync('$path.${i+1}'); On 2015/11/04 23:00:29, Brian Wilkerson wrote: > ...
5 years, 1 month ago (2015-11-05 16:40:27 UTC) #3
scheglov
5 years, 1 month ago (2015-11-05 16:40:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
61ee6dff5f5e8a9da1bd7b26645f8be2926a6df4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698