Issue 1418143004: Fix cctest/test-spaces/CompactionSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1418143004: Fix cctest/test-spaces/CompactionSpace (Closed)

Created:
5 years, 1 month ago by MTBrandyberry

Modified:
5 years, 1 month ago

Reviewers:
Hannes Payer (out of office), Michael Lippautz

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix cctest/test-spaces/CompactionSpace kExpectedPages should be ceil(kNumObjects / kNumObjectsPerPage) R=mlippautz@chromium.org, hpayer@chromium.org BUG= Committed: https://crrev.com/a0e7a76a81da71bfda6e335972a1ea677504cea9 Cr-Commit-Position: refs/heads/master@{#31605}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	test/cctest/test-spaces.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418143004/1

5 years, 1 month ago (2015-10-27 13:20:56 UTC) #4

commit-bot: I haz the power

5 years, 1 month ago (2015-10-27 13:41:38 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a0e7a76a81da71bfda6e335972a1ea677504cea9
Cr-Commit-Position: refs/heads/master@{#31605}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages