third_party/WebKit/Source/core/css/RuleFeature.h - Issue 1418133013: CSS: Reduce style invalidation with sibling combinators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/RuleFeature.h

Issue 1418133013: CSS: Reduce style invalidation with sibling combinators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use enum Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/invalidation/invalidation-set-with-adjacent-combinators-expected.txt ('k') | third_party/WebKit/Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/RuleFeature.h

diff --git a/third_party/WebKit/Source/core/css/RuleFeature.h b/third_party/WebKit/Source/core/css/RuleFeature.h

index 79fd97c86df80bf10d37fba02db3a59bab9124f6..1fc6849eb422186f495623edfdde829e8642e01b 100644

--- a/third_party/WebKit/Source/core/css/RuleFeature.h

+++ b/third_party/WebKit/Source/core/css/RuleFeature.h

@@ -165,7 +165,8 @@ private:

enum UseFeaturesType { UseFeatures, ForceSubtree };

- std::pair<const CSSSelector*, UseFeaturesType> extractInvalidationSetFeatures(const CSSSelector&, InvalidationSetFeatures&, bool negated);

+ enum PositionType { Subject, Ancestor };

+ std::pair<const CSSSelector*, UseFeaturesType> extractInvalidationSetFeatures(const CSSSelector&, InvalidationSetFeatures&, PositionType, CSSSelector::PseudoType = CSSSelector::PseudoUnknown);

void addFeaturesToInvalidationSet(InvalidationSet&, const InvalidationSetFeatures&);

void addFeaturesToInvalidationSets(const CSSSelector*, InvalidationSetFeatures* siblingFeatures, InvalidationSetFeatures& descendantFeatures);