Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1418133011: Remove the named item getters on TextTrackList and TextTrackCueList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index f1334c3da09a4fd48e046b02ace7b7001c81cc40..de7d65b0cafdf89cbe17223d38e0b481675872d8 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -823,7 +823,7 @@ void HTMLMediaElement::loadInternal()
m_textTracksWhenResourceSelectionBegan.clear();
if (m_textTracks) {
for (unsigned i = 0; i < m_textTracks->length(); ++i) {
- TextTrack* track = m_textTracks->item(i);
+ TextTrack* track = m_textTracks->anonymousIndexedGetter(i);
if (track->mode() != TextTrack::disabledKeyword())
m_textTracksWhenResourceSelectionBegan.append(track);
}
@@ -3166,11 +3166,12 @@ bool HTMLMediaElement::hasClosedCaptions() const
{
if (m_textTracks) {
for (unsigned i = 0; i < m_textTracks->length(); ++i) {
- if (m_textTracks->item(i)->readinessState() == TextTrack::FailedToLoad)
+ TextTrack* track = m_textTracks->anonymousIndexedGetter(i);
+ if (track->readinessState() == TextTrack::FailedToLoad)
continue;
- if (m_textTracks->item(i)->kind() == TextTrack::captionsKeyword()
- || m_textTracks->item(i)->kind() == TextTrack::subtitlesKeyword())
+ if (track->kind() == TextTrack::captionsKeyword()
+ || track->kind() == TextTrack::subtitlesKeyword())
return true;
}
}
@@ -3295,7 +3296,7 @@ void HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured()
// non-default tracks should be displayed based on language preferences if
// the user has turned captions on).
for (unsigned i = 0; i < m_textTracks->length(); ++i) {
- TextTrack* textTrack = m_textTracks->item(i);
+ TextTrack* textTrack = m_textTracks->anonymousIndexedGetter(i);
String kind = textTrack->kind();
if (kind == TextTrack::subtitlesKeyword() || kind == TextTrack::captionsKeyword())

Powered by Google App Engine
This is Rietveld 408576698