Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 1418133007: fix for teeny strokes (Closed)

Created:
5 years, 2 months ago by caryclark
Modified:
5 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix for teeny strokes Pass the scale before evaluating degenerate line segments. This does not change other GMs. R=reed@google.com BUG=478337 Committed: https://skia.googlesource.com/skia/+/950305ec77702639fe6ad1923f7b8d828ccef634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M gm/strokes.cpp View 2 chunks +37 lines, -0 lines 0 comments Download
M src/core/SkStroke.cpp View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418133007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418133007/1
5 years, 2 months ago (2015-10-23 20:14:21 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-23 20:29:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418133007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418133007/1
5 years, 1 month ago (2015-10-26 13:08:53 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-10-26 13:08:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3804) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 1 month ago (2015-10-26 13:11:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418133007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418133007/1
5 years, 1 month ago (2015-10-26 14:27:54 UTC) #12
reed1
lgtm
5 years, 1 month ago (2015-10-26 14:44:33 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 15:17:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/950305ec77702639fe6ad1923f7b8d828ccef634

Powered by Google App Engine
This is Rietveld 408576698