Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 141813005: [rAC, OSX] Fix field alignment. (Closed)

Created:
6 years, 10 months ago by groby-ooo-7-16
Modified:
6 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[rAC, OSX] Fix field alignment. This fixes an issue around field alignment when the dialog displays scroll bars. Previous scroll would not only display the currently active field, but also scroll the entire view 15 pixels to the side, thus truncating the left edge. Since the scroll view is meant to scroll only in y-direction, this simply forces the X coordinate to 0. BUG=332678 R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/autofill/autofill_details_container.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
6 years, 10 months ago (2014-02-03 20:31:09 UTC) #1
Evan Stade
rslgtm
6 years, 10 months ago (2014-02-03 20:48:47 UTC) #2
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 10 months ago (2014-02-03 20:51:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/141813005/1
6 years, 10 months ago (2014-02-03 20:53:07 UTC) #4
commit-bot: I haz the power
Change committed as 248599
6 years, 10 months ago (2014-02-03 22:48:34 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:48:35 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 22:48:37 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698