Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 141813002: Adding SK_API to SkGLContextHelper and SkNullGLContext for use in blink unit test component build (Closed)

Created:
6 years, 11 months ago by Justin Novosad
Modified:
6 years, 11 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Adding SK_API to SkGLContextHelper and SkNullGLContext for use in blink unit test component build BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13119

Patch Set 1 #

Patch Set 2 : fix typo #

Patch Set 3 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/gpu/gl/SkGLContextHelper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/gl/SkNullGLContext.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Novosad
PTAL
6 years, 11 months ago (2014-01-17 16:09:37 UTC) #1
bsalomon
On 2014/01/17 16:09:37, junov wrote: > PTAL lgtm
6 years, 11 months ago (2014-01-17 16:44:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/junov@chromium.org/141813002/60001
6 years, 11 months ago (2014-01-17 16:46:59 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 16:59:08 UTC) #4
Message was sent while issue was closed.
Change committed as 13119

Powered by Google App Engine
This is Rietveld 408576698