Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1418123004: fix import uri completion exception - fixes #24709 (Closed)

Created:
5 years, 2 months ago by danrubel
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -12 lines) Patch
M pkg/analysis_server/lib/src/services/completion/uri_contributor.dart View 2 chunks +21 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/services/completion/uri_contributor_test.dart View 3 chunks +78 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 2 months ago (2015-10-23 17:50:04 UTC) #2
scheglov
LGTM
5 years, 2 months ago (2015-10-23 18:27:32 UTC) #3
danrubel
5 years, 2 months ago (2015-10-23 18:55:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5bd191ee12674f0fb60cc887be4c97bdd6a9ca79 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698