third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h - Issue 1418113002: RTCPeerConnection.generateCertificate taking AlgorithmIdentifier and using WebCrypto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

Issue 1418113002: RTCPeerConnection.generateCertificate taking AlgorithmIdentifier and using WebCrypto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/DEPS ('k') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp » ('j') | third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

index 5680f178daa6dfd33da8a30781f91eaf2cfff764..f6eefc779daff28eb99ac450e97e0d1d18950a3d 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

+++ b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h

@@ -35,6 +35,7 @@

#include "bindings/core/v8/ScriptPromise.h"

#include "core/dom/ActiveDOMObject.h"

#include "modules/EventTargetModules.h"

+#include "modules/crypto/NormalizeAlgorithm.h"

#include "modules/mediastream/MediaStream.h"

#include "modules/mediastream/RTCIceCandidate.h"

#include "platform/AsyncMethodRunner.h"

@@ -81,7 +82,9 @@ public:

void updateIce(const Dictionary& rtcConfiguration, const Dictionary& mediaConstraints, ExceptionState&);

- static ScriptPromise generateCertificate(ScriptState*, const Dictionary& keygenAlgorithm, ExceptionState&);

+ // Certificate management

+ // http://w3c.github.io/webrtc-pc/#sec.cert-mgmt

+ static ScriptPromise generateCertificate(ScriptState*, const AlgorithmIdentifier& keygenAlgorithm, ExceptionState&);

// DEPRECATED

void addIceCandidate(RTCIceCandidate*, ExceptionState&);