third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html - Issue 1418113002: RTCPeerConnection.generateCertificate taking AlgorithmIdentifier and using WebCrypto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html

Issue 1418113002: RTCPeerConnection.generateCertificate taking AlgorithmIdentifier and using WebCrypto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Hello, WebCrypto Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-generateCertificate.html » ('j') | third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html

diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html

index f256f8576b462c794c23803ff73e3a29fe6285a2..dc829d70f9393933a07f4ed10063e5386f152a49 100644

--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html

+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html

@@ -71,7 +71,7 @@ var certRSA = null;

var certECDSA = null;

function testCertificates1RSA()

hta - Chromium 2015/10/23 06:55:00 Nit: Blank lines above function declaration for re

hbos_chromium 2015/10/23 09:59:05 Done.

{

- webkitRTCPeerConnection.generateCertificate({ name: "RSASSA-PKCS1-v1_5", modulusLength: 2048, publicExponent: 65537 })

+ webkitRTCPeerConnection.generateCertificate({ name: "RSASSA-PKCS1-v1_5", modulusLength: 2048, publicExponent: new Uint8Array([1, 0, 1]), hash: "SHA-256" })

.then(function(certificate) {

certRSA = certificate;

shouldNotThrow('new webkitRTCPeerConnection({certificates:[certRSA]}, null);');