content/renderer/media/rtc_certificate_generator.cc - Issue 1418113002: RTCPeerConnection.generateCertificate taking AlgorithmIdentifier and using WebCrypto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_certificate_generator.cc

Issue 1418113002: RTCPeerConnection.generateCertificate taking AlgorithmIdentifier and using WebCrypto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase with master Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/rtc_certificate_generator.h ('k') | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_certificate_generator.cc

diff --git a/content/renderer/media/rtc_certificate_generator.cc b/content/renderer/media/rtc_certificate_generator.cc

index 945c6469c56b39a03967f8808d11a44dcfa173ba..757cad0b78bc021db07b5a2d3aa56689b515d529 100644

--- a/content/renderer/media/rtc_certificate_generator.cc

+++ b/content/renderer/media/rtc_certificate_generator.cc

@@ -136,7 +136,7 @@ void RTCCertificateGenerator::generateCertificate(

const blink::WebURL& url,

const blink::WebURL& first_party_for_cookies,

blink::WebCallbacks<blink::WebRTCCertificate*, void>* observer) {

- DCHECK(isValidKeyParams(key_params));

+ DCHECK(isSupportedKeyParams(key_params));

#if defined(ENABLE_WEBRTC)

const scoped_refptr<base::SingleThreadTaskRunner> main_thread =

@@ -159,7 +159,7 @@ void RTCCertificateGenerator::generateCertificate(

#endif

}

-bool RTCCertificateGenerator::isValidKeyParams(

+bool RTCCertificateGenerator::isSupportedKeyParams(

const blink::WebRTCKeyParams& key_params) {

return WebRTCKeyParamsToKeyParams(key_params).IsValid();

}