RTCPeerConnection.generateCertificate taking AlgorithmIdentifier and using WebCrypto

third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 16 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebCryptoAlgorithmParams_h
 #define WebCryptoAlgorithmParams_h
 
 #include "WebCommon.h"
 #include "WebCryptoAlgorithm.h"
 #include "WebCryptoKey.h"
+#include "WebCryptoUtil.h"
 #include "WebVector.h"
 
 namespace blink {
 
 // NOTE: For documentation on the meaning of each of the parameters see the
 //       Web crypto spec:
 //
 //       http://www.w3.org/TR/WebCryptoAPI
 //
 //       For the most part, the parameters in the spec have the same name,
@@ skipping 173 matching lines @@
     {
         BLINK_ASSERT(!hash.isNull());
     }
 
     virtual WebCryptoAlgorithmParamsType type() const { return WebCryptoAlgorithmParamsTypeRsaHashedKeyGenParams; }
 
     unsigned modulusLengthBits() const { return m_modulusLengthBits; }
     const WebVector<unsigned char>& publicExponent() const { return m_publicExponent; }
     const WebCryptoAlgorithm& hash() const { return m_hash; }
 
+    // Converts the public exponent (BigInteger) to unsigned int. Returns true on success (if its value is not too large).
+    bool publicExponentToUint(unsigned& result) const

[eroman, 2015/10/27 18:24:11]

I suggest removing this function, and just using WebCryptoUtil.h directly.

For instance:

#include ...WebCryptoUtil.h
...
  blink::bigIntegerToUint(params->publicExponent(), result);


At the callsites.

[hbos_chromium, 2015/10/28 10:35:05]

Done.

+    {
+        return bigIntegerToUint(m_publicExponent, result);
+    }
 private:
     const unsigned m_modulusLengthBits;
     const WebVector<unsigned char> m_publicExponent;
     const WebCryptoAlgorithm m_hash;
 };
 
 class WebCryptoRsaOaepParams : public WebCryptoAlgorithmParams {
 public:
     WebCryptoRsaOaepParams(bool hasLabel, const unsigned char* label, unsigned labelSize)
         : m_hasLabel(hasLabel)
@@ skipping 135 matching lines @@
     unsigned iterations() const { return m_iterations; }
 
 private:
     const WebVector<unsigned char> m_salt;
     const unsigned m_iterations;
 };
 
 } // namespace blink
 
 #endif