RTCPeerConnection.generateCertificate taking AlgorithmIdentifier and using WebCrypto

third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 209 matching lines @@
     {
         BLINK_ASSERT(!hash.isNull());
     }
 
     virtual WebCryptoAlgorithmParamsType type() const { return WebCryptoAlgorithmParamsTypeRsaHashedKeyGenParams; }
 
     unsigned modulusLengthBits() const { return m_modulusLengthBits; }
     const WebVector<unsigned char>& publicExponent() const { return m_publicExponent; }
     const WebCryptoAlgorithm& hash() const { return m_hash; }
 
+    // Converts the public exponent (big-endian WebCrypto BigInteger), with or without leading zeros, to unsigned int. Returns true on success.
+    bool publicExponentToUint32(unsigned* result) const

[eroman, 2015/10/23 19:13:04]

Blink style favors the use of references over out pointers:
   unsigned& result

[hbos_chromium, 2015/10/26 13:21:32]

Done.

+    {
+        if (m_publicExponent.size() == 0)

[eroman, 2015/10/23 19:13:04]

While you are editing things, can you delete these two lines?

(Rejecting empty BigIntegers was an older behavior of WebCrypto, and the spec
now defines empty as meaning zero. In practice this was getting re-written to 0
at a higher layer so it wasn't actually reachable.)

[hbos_chromium, 2015/10/26 13:21:32]

Done.

+            return false;
+
+        *result = 0;
+        for (size_t i = 0; i < m_publicExponent.size(); ++i) {
+            size_t iReversed = m_publicExponent.size() - i - 1;
+
+            if (iReversed >= sizeof(*result) && m_publicExponent[i])
+                return false; // Too large for a uint.
+
+            *result |= m_publicExponent[i] << 8 * iReversed;
+        }
+        return true;
+    }
 private:
     const unsigned m_modulusLengthBits;
     const WebVector<unsigned char> m_publicExponent;
     const WebCryptoAlgorithm m_hash;
 };
 
 class WebCryptoRsaOaepParams : public WebCryptoAlgorithmParams {
 public:
     WebCryptoRsaOaepParams(bool hasLabel, const unsigned char* label, unsigned labelSize)
         : m_hasLabel(hasLabel)
@@ skipping 135 matching lines @@
     unsigned iterations() const { return m_iterations; }
 
 private:
     const WebVector<unsigned char> m_salt;
     const unsigned m_iterations;
 };
 
 } // namespace blink
 
 #endif