Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 14181002: Use pangocairo for all Linux builds (Closed)

Created:
7 years, 8 months ago by spang
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Untangle pango usage from use_x11 This allows pango to be enabled independently of X11. It defaults to enabled on all X11 & Linux platforms.

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : introduce use_pango #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -46 lines) Patch
M build/common.gypi View 1 2 2 chunks +7 lines, -0 lines 1 comment Download
D content/common/font_list_linux.cc View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
A + content/common/font_list_pango.cc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
spang
7 years, 8 months ago (2013-04-11 18:43:06 UTC) #1
Mostyn Bramley-Moore
I'm working on support for embedded linux targets, where pango is usually not available. Can ...
7 years, 8 months ago (2013-04-11 18:55:08 UTC) #2
spang
On 2013/04/11 18:55:08, Mostyn Bramley-Moore wrote: > I'm working on support for embedded linux targets, ...
7 years, 8 months ago (2013-04-11 19:04:05 UTC) #3
Mostyn Bramley-Moore
https://codereview.chromium.org/14181002/diff/8003/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/14181002/diff/8003/build/common.gypi#newcode441 build/common.gypi:441: ['OS=="win" or OS=="mac" or OS=="ios" or OS=="android"', { From ...
7 years, 8 months ago (2013-04-11 22:08:32 UTC) #4
Mostyn Bramley-Moore
There are some pango usage in the following files that could also check use_pango==1: ui/ui.gyp ...
7 years, 8 months ago (2013-04-12 08:34:45 UTC) #5
Mostyn Bramley-Moore
Submitted a newer version of this (which some changes) here: https://codereview.chromium.org/15102010/
7 years, 7 months ago (2013-05-13 19:57:56 UTC) #6
Mostyn Bramley-Moore
7 years, 7 months ago (2013-05-24 08:09:33 UTC) #7
On 2013/05/13 19:57:56, Mostyn Bramley-Moore wrote:
> Submitted a newer version of this (which some changes) here:
> https://codereview.chromium.org/15102010/

15102010 has landed, I think you can close this issue now.

Powered by Google App Engine
This is Rietveld 408576698