Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1418093007: Revert of Check that array length stays a safe integer in Array.prototype.push (Closed)

Created:
5 years, 1 month ago by Dan Ehrenberg
Modified:
5 years, 1 month ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Check that array length stays a safe integer in Array.prototype.push (patchset #7 id:120001 of https://codereview.chromium.org/1428483002/ ) Reason for revert: Caused for-in-opt test to fail Original issue's description: > Check that array length stays a safe integer in Array.prototype.push > > This patch adds a check in Array.prototype.push to assert that the new > length does not become greater than 2**53-1. Such a length would be > dangerous because integer arithmetic becomes imprecise after the > boundary. The check is also required by a test262 test. > > R=adamk > LOG=Y > BUG=v8:3087 > > Committed: https://crrev.com/e68adf4548dd101dc08fcbff14444152fb1b7fe7 > Cr-Commit-Position: refs/heads/master@{#31588} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3087 Committed: https://crrev.com/78abedb94431a233842fcb2f7a910805a05bed09 Cr-Commit-Position: refs/heads/master@{#31590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M src/js/array.js View 1 chunk +0 lines, -9 lines 0 comments Download
M src/messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/array-length.js View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Dan Ehrenberg
Created Revert of Check that array length stays a safe integer in Array.prototype.push
5 years, 1 month ago (2015-10-27 05:45:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418093007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418093007/1
5 years, 1 month ago (2015-10-27 05:45:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 05:45:53 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78abedb94431a233842fcb2f7a910805a05bed09 Cr-Commit-Position: refs/heads/master@{#31590}
5 years, 1 month ago (2015-10-27 05:46:33 UTC) #4
Michael Achenbach
Please also post a link to the failing builder. I think if you meant arm64 ...
5 years, 1 month ago (2015-10-27 08:52:20 UTC) #5
Jakob Kummerow
You can probably just reland this. mjsunit/for-in-opt was recently re-enabled and flushed out an old ...
5 years, 1 month ago (2015-10-27 14:45:53 UTC) #6
Dan Ehrenberg
5 years, 1 month ago (2015-10-27 16:30:05 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1424823005/ by littledan@chromium.org.

The reason for reverting is: The test failure was unrelated; relanding..

Powered by Google App Engine
This is Rietveld 408576698