Stop logging users' history urls when url db is not available

Stop logging users' history urls when url db is not available

At present, if data_provider fails to query history data for a url, it
will dump the url to logcat. This might happen in an extreme case that
somehow the url db is corrupted, and we end up logging all users'
history. This CL makes sure that this logging is only eneblaed by
developers.

BUG=474708
Committed: https://crrev.com/87d81af73e05b6a06162f55413451229f05a8b15
Cr-Commit-Position: refs/heads/master@{#355670}

[Ian Wen, 2015-10-22 22:31:42]

ianwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ian Wen, 2015-10-22 22:31:42]

Dan, could you ptal this trivial change?

[gone, 2015-10-22 22:33:47]

https://codereview.chromium.org/1418093004/diff/1/chrome/browser/android/hist...
File chrome/browser/android/history_report/data_provider.cc (right):

https://codereview.chromium.org/1418093004/diff/1/chrome/browser/android/hist...
chrome/browser/android/history_report/data_provider.cc:24: const bool is_debug =
false;
aren't variables like this supposed to go inside the anonymous namespace?  do
you have an example file you're following?

[Ian Wen, 2015-10-22 22:46:32]

On 2015/10/22 22:33:47, dfalcantara wrote:
>
https://codereview.chromium.org/1418093004/diff/1/chrome/browser/android/hist...
> File chrome/browser/android/history_report/data_provider.cc (right):
> 
>
https://codereview.chromium.org/1418093004/diff/1/chrome/browser/android/hist...
> chrome/browser/android/history_report/data_provider.cc:24: const bool is_debug
=
> false;
> aren't variables like this supposed to go inside the anonymous namespace?  do
> you have an example file you're following?

Done.

[gone, 2015-10-22 22:48:33]

lgtm

[Ian Wen, 2015-10-22 22:48:53]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2015-10-22 22:49:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418093004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418093004/20001

[commit-bot: I haz the power, 2015-10-22 23:28:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-22 23:30:37]

Patchset 2 (id:??) landed as
https://crrev.com/87d81af73e05b6a06162f55413451229f05a8b15
Cr-Commit-Position: refs/heads/master@{#355670}