Issue 1418043005: dart2js: Set inferred return types for async, async*, and sync* methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1418043005: dart2js: Set inferred return types for async, async, and sync methods. (Closed)

Created:
5 years, 1 month ago by asgerf

Modified:
5 years, 1 month ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: Set inferred return types for async, async*, and sync* methods. Previously these were assumed to return dynamic. Now the return type is the concrete class being returned: async -> _Future async* -> _ControllerStream sync* -> _SyncStarIterable R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/dff4cc11d76c817bf8dd5140a2e264a762d80deb

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -16 lines)			Patch
M	pkg/compiler/lib/src/common/backend_api.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/inferrer_visitor.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart	View	2 chunks	+34 lines, -15 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend_helpers.dart	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/types/types.dart	View	2 chunks	+27 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

asgerf

5 years, 1 month ago (2015-11-03 14:02:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dff4cc11d76c817bf8dd5140a2e264a762d80deb (presubmit successful).