Hide Port privates

Hide Port privates

utils.expose now accepts a third parameter (readonly properties).

BUG=324859
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247683

[not at google - send to devlin, 2014-01-27 23:21:56]

https://codereview.chromium.org/141803016/diff/1/chrome/renderer/resources/ex...
File chrome/renderer/resources/extensions/utils.js (right):

https://codereview.chromium.org/141803016/diff/1/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/utils.js:55: // methods |funcs| in a public
wrapper class that it returns.
explain |props| in this comment as well, though what's the difference
implementation wise? Could the implementation of |funcs| just do the same and
access the underlying properties, whether they be functions or otherwise?

I.e. the implementation of this method deletes references to |funcs| entirely.

https://codereview.chromium.org/141803016/diff/1/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/utils.js:81: }
Hm this is pretty tricky.

You should make this settable too; maybe an app wants to instrument the port
getters or something. The trick then would be to make sure it can override it
etc without breaking things.

[Fady Samuel, 2014-01-28 20:45:45]

PTAL

https://codereview.chromium.org/141803016/diff/1/chrome/renderer/resources/ex...
File chrome/renderer/resources/extensions/utils.js (right):

https://codereview.chromium.org/141803016/diff/1/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/utils.js:55: // methods |funcs| in a public
wrapper class that it returns.
On 2014/01/27 23:21:56, kalman wrote:
> explain |props| in this comment as well, though what's the difference
> implementation wise? Could the implementation of |funcs| just do the same and
> access the underlying properties, whether they be functions or otherwise?
> 
> I.e. the implementation of this method deletes references to |funcs| entirely.

Done. As per our offline discussion, it's fairly messy to merge functions and
properties. I'm leaving them separate.

https://codereview.chromium.org/141803016/diff/1/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/utils.js:81: }
On 2014/01/27 23:21:56, kalman wrote:
> Hm this is pretty tricky.
> 
> You should make this settable too; maybe an app wants to instrument the port
> getters or something. The trick then would be to make sure it can override it
> etc without breaking things.

Done.

[not at google - send to devlin, 2014-01-28 22:25:06]

lgtm

https://codereview.chromium.org/141803016/diff/20001/chrome/renderer/resource...
File chrome/renderer/resources/extensions/utils.js (right):

https://codereview.chromium.org/141803016/diff/20001/chrome/renderer/resource...
chrome/renderer/resources/extensions/utils.js:80: return impl[prop];
inline |impl|?

[Fady Samuel, 2014-01-28 23:25:34]

Addressed nit. CQ'ing.

[commit-bot: I haz the power, 2014-01-28 23:26:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/141803016/40001

[commit-bot: I haz the power, 2014-01-29 01:25:44]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-29 02:55:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/141803016/40001

[commit-bot: I haz the power, 2014-01-29 04:04:44]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-29 04:06:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/141803016/60001

[commit-bot: I haz the power, 2014-01-29 04:49:58]

Retried try job too often on mac_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-29 12:28:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/141803016/60001

[commit-bot: I haz the power, 2014-01-29 13:52:56]

Change committed as 247683