Issue 1417983006: XFA: Simplify CPDFSDK_PageView::PageView_OnDraw().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1417983006: XFA: Simplify CPDFSDK_PageView::PageView_OnDraw(). (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

XFA: Simplify CPDFSDK_PageView::PageView_OnDraw(). The clip parameter is never NULL. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f0e2e1b09cf1ce0e537888a99f04be6f10edcada

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -11 lines)			Patch
M	fpdfsdk/include/fsdk_mgr.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fpdfformfill.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fsdk_mgr.cpp	View	2 chunks	+7 lines, -9 lines	0 comments	Download

Total messages: 4 (1 generated)

Lei Zhang

5 years, 1 month ago (2015-11-02 21:28:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f0e2e1b09cf1ce0e537888a99f04be6f10edcada (presubmit successful).