Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1417973009: Fix memory leak in FXJS_ReleaseRuntime. (Closed)

Created:
5 years, 1 month ago by Oliver Chang
Modified:
5 years, 1 month ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix memory leak in FXJS_ReleaseRuntime. Should fix a bunch of JS related memory leaks reported by LSan/DrMemory. R=jochen@chromium.org, thestig@chromium.org, tsepez@chromium.org BUG=pdfium:242 Committed: https://pdfium.googlesource.com/pdfium/+/fbbb3c3de517309b6808d7a8f4c441aa0abf7065

Patch Set 1 #

Patch Set 2 : cleanup and fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Oliver Chang
ptal
5 years, 1 month ago (2015-10-26 23:57:13 UTC) #4
Tom Sepez
On 2015/10/26 23:57:13, Oliver Chang wrote: > ptal Looks good, but lets have Jochen double-check.
5 years, 1 month ago (2015-10-27 00:45:31 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-10-27 12:16:55 UTC) #8
Oliver Chang
5 years, 1 month ago (2015-10-27 16:21:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
fbbb3c3de517309b6808d7a8f4c441aa0abf7065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698