Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 1417973006: [turbofan] Non-dictionary prototype maps are always stable. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Non-dictionary prototype maps are always stable. We don't need to have an (untested) fallback for the case that a prototype map is not stable when specializing a named property, because prototype maps are always stable (which is now guarded by a DCHECK in CompilationDependencies). Less (dead) code is better code. R=verwaest@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/daf76e6d14b08c3949c8c80dfa2d1b1787947764 Cr-Commit-Position: refs/heads/master@{#31524}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -62 lines) Patch
M src/compiler/js-native-context-specialization.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +21 lines, -62 lines 3 comments Download

Messages

Total messages: 11 (2 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-23 11:57:02 UTC) #1
Benedikt Meurer
Hey Toon, As discussed offline. This also reduces code duplication (at least a little bit, ...
5 years, 2 months ago (2015-10-23 11:57:56 UTC) #2
Jarin
lgtm https://codereview.chromium.org/1417973006/diff/1/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/1417973006/diff/1/src/compiler/js-native-context-specialization.cc#newcode899 src/compiler/js-native-context-specialization.cc:899: for (PrototypeIterator j(map);; j.Advance()) { Does not it ...
5 years, 2 months ago (2015-10-23 13:09:35 UTC) #4
Toon Verwaest
https://codereview.chromium.org/1417973006/diff/1/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/1417973006/diff/1/src/compiler/js-native-context-specialization.cc#newcode757 src/compiler/js-native-context-specialization.cc:757: What Object.prototype.x? Object.prototype has a null prototype, there won't ...
5 years, 2 months ago (2015-10-23 13:45:40 UTC) #5
Benedikt Meurer
https://codereview.chromium.org/1417973006/diff/1/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/1417973006/diff/1/src/compiler/js-native-context-specialization.cc#newcode757 src/compiler/js-native-context-specialization.cc:757: NotFound case is not implemented.
5 years, 2 months ago (2015-10-23 13:56:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417973006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417973006/1
5 years, 2 months ago (2015-10-23 13:56:40 UTC) #8
Toon Verwaest
lgtm
5 years, 2 months ago (2015-10-23 13:56:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 13:57:59 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 13:58:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/daf76e6d14b08c3949c8c80dfa2d1b1787947764
Cr-Commit-Position: refs/heads/master@{#31524}

Powered by Google App Engine
This is Rietveld 408576698