Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

Issue 1417973002: [Cronet] Switch from InstrumentationTest to junit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
index f9f9782949b51dbc378d15b941468f8eac41a1a6..0e0737dc6155b82a9182fa4bd30aa0110d57ce83 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
@@ -20,8 +20,11 @@ public class NetworkChangeNotifierTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
public void testNetworkChangeNotifierIsInitialized() throws Exception {
- CronetTestActivity activity = launchCronetTestApp();
- assertNotNull(activity);
+ CronetTestFramework testFramework = startCronetTestFramework();
+ assertNotNull(testFramework);
+ // Let Cronet UI thread initialization complete so
+ // NetworkChangeNotifier is initialized for the test.
+ NetworkChangeNotifierTestUtil.flushUiThreadTaskQueue();
xunjieli 2015/10/22 18:41:24 Ah, I see. Thanks for fixing this!
pauljensen 2015/10/23 11:35:50 Acknowledged.
assertTrue(NetworkChangeNotifierUtil.isTestIPAddressObserverCalled());
}
}

Powered by Google App Engine
This is Rietveld 408576698