Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1417963005: Retry socket.timeout as well as SSL timeouts (ssl.SSLError is a subclass of socket.error). (Closed)

Created:
5 years, 2 months ago by dsansome
Modified:
5 years, 2 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M rietveld.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/rietveld_test.py View 3 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dsansome
+pgervais for OWNERS
5 years, 2 months ago (2015-10-22 00:22:27 UTC) #2
Sergey Berezin
LGTM, thanks! I think I just tripped up on it in my CL...
5 years, 2 months ago (2015-10-22 00:27:46 UTC) #3
dsansome
On 2015/10/22 00:27:46, Sergey Berezin wrote: > LGTM, thanks! > > I think I just ...
5 years, 2 months ago (2015-10-22 00:28:26 UTC) #4
pgervais
On 2015/10/22 00:28:26, dsansome wrote: > On 2015/10/22 00:27:46, Sergey Berezin wrote: > > LGTM, ...
5 years, 2 months ago (2015-10-22 00:34:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417963005/1
5 years, 2 months ago (2015-10-22 00:37:34 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 00:39:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297234

Powered by Google App Engine
This is Rietveld 408576698