core/src/fpdfdoc/doc_basic.cpp - Issue 1417933002: Add type cast definitions for CPDF_String.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfdoc/doc_basic.cpp

Issue 1417933002: Add type cast definitions for CPDF_String. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfdoc/doc_basic.cpp

diff --git a/core/src/fpdfdoc/doc_basic.cpp b/core/src/fpdfdoc/doc_basic.cpp

index bbf51139adfdb115b9c47d6b4b7c350d673ec6e1..cbf956bd9b0a05b67a3475b39fe3641f0a5dfea2 100644

--- a/core/src/fpdfdoc/doc_basic.cpp

+++ b/core/src/fpdfdoc/doc_basic.cpp

@@ -406,8 +406,7 @@ static void FPDFDOC_FILESPEC_SetFileName(CPDF_Object* pObj,

} else {

wsStr = FILESPEC_EncodeFileName(wsFileName);

}

- int32_t iType = pObj->GetType();

- if (iType == PDFOBJ_STRING) {

+ if (pObj->IsString()) {

pObj->SetString(CFX_ByteString::FromUnicode(wsStr));

} else if (CPDF_Dictionary* pDict = pObj->AsDictionary()) {

pDict->SetAtString(FX_BSTRC("F"), CFX_ByteString::FromUnicode(wsStr));

« no previous file with comments | « core/src/fpdfdoc/doc_ap.cpp ('k') | core/src/fpdfdoc/doc_bookmark.cpp » ('j') | no next file with comments »