Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3006)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/src/fpdfdoc/doc_basic.cpp

Issue 1417933002: Add type cast definitions for CPDF_String. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/src/fpdfdoc/doc_action.cpp ('K') | « core/src/fpdfdoc/doc_ap.cpp ('k') | core/src/fpdfdoc/doc_bookmark.cpp » ('j') | core/src/fpdfdoc/doc_formfield.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fpdfdoc/doc_basic.cpp
diff --git a/core/src/fpdfdoc/doc_basic.cpp b/core/src/fpdfdoc/doc_basic.cpp
index bbf51139adfdb115b9c47d6b4b7c350d673ec6e1..cbf956bd9b0a05b67a3475b39fe3641f0a5dfea2 100644
--- a/core/src/fpdfdoc/doc_basic.cpp
+++ b/core/src/fpdfdoc/doc_basic.cpp
@@ -406,8 +406,7 @@ static void FPDFDOC_FILESPEC_SetFileName(CPDF_Object* pObj,
} else {
wsStr = FILESPEC_EncodeFileName(wsFileName);
}
- int32_t iType = pObj->GetType();
- if (iType == PDFOBJ_STRING) {
+ if (pObj->IsString()) {
pObj->SetString(CFX_ByteString::FromUnicode(wsStr));
} else if (CPDF_Dictionary* pDict = pObj->AsDictionary()) {
pDict->SetAtString(FX_BSTRC("F"), CFX_ByteString::FromUnicode(wsStr));
« core/src/fpdfdoc/doc_action.cpp ('K') | « core/src/fpdfdoc/doc_ap.cpp ('k') | core/src/fpdfdoc/doc_bookmark.cpp » ('j') | core/src/fpdfdoc/doc_formfield.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698