core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp - Issue 1417933002: Add type cast definitions for CPDF_String.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

Issue 1417933002: Add type cast definitions for CPDF_String. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

index c34d8122f8671e1a6b1f93a304e3eb672f5365b9..84d1301c608b250944d3b61816241fcb05c33480 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

@@ -374,7 +374,7 @@ CFX_ByteTextBuf& operator<<(CFX_ByteTextBuf& buf, const CPDF_Object* pObj) {

break;

case PDFOBJ_STRING: {

CFX_ByteString str = pObj->GetString();

- FX_BOOL bHex = ((CPDF_String*)pObj)->IsHex();

+ FX_BOOL bHex = pObj->AsString()->IsHex();

Tom Sepez 2015/10/21 17:12:50 nit: local(s) not needed.

dsinclair 2015/10/21 17:40:01 Done.

buf << PDF_EncodeString(str, bHex);

break;

}