Add type cast definitions for CPDF_String.

Add type cast definitions for CPDF_String.

This Cl adds ToString, CPDF_Object::AsString and CPDF_Object::IsString and
updates the src to use them as needed.

BUG=pdfium:201
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/53d3ab125ef583be8cfac907b308a6551b93067a

[dsinclair, 2015-10-21 15:28:12]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2015-10-21 15:28:13]

PTAL.

[Lei Zhang, 2015-10-21 16:55:57]

lgtm, with lots of nits

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp:916: 
no blank line

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:1362: if
(pArray->GetElementValue(i)->AsString())
IsString ?

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp:142: 
no trailing blank line

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:68: const CPDF_String*
pString = AsString();
Maybe do AsString()->m_String here, instead of twice on the next 2 lines.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:338: 
no blank line

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_action...
File core/src/fpdfdoc/doc_action.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_action...
core/src/fpdfdoc/doc_action.cpp:136: 
no blank line

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_formfi...
File core/src/fpdfdoc/doc_formfield.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:430: return !pValue->GetString().IsEmpty();
This should still return 0 or 1, rather than true/false.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:537: if (pValue->GetInteger() == index)
just return pValue->GetInteger() == index;

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/formfiller/FFL_...
File fpdfsdk/src/formfiller/FFL_Utils.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/formfiller/FFL_...
fpdfsdk/src/formfiller/FFL_Utils.cpp:84: // TRACE(pObj->AsString()->GetString()
+ "\n");
This entire function just needs to go.

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/fsdk_baseform.cpp
File fpdfsdk/src/fsdk_baseform.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/fsdk_baseform.c...
fpdfsdk/src/fsdk_baseform.cpp:2233: 
no blank line

[dsinclair, 2015-10-21 17:08:05]

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp:916: 
On 2015/10/21 16:55:56, Lei Zhang wrote:
> no blank line

Done.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:1362: if
(pArray->GetElementValue(i)->AsString())
On 2015/10/21 16:55:56, Lei Zhang wrote:
> IsString ?

Done.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp:142: 
On 2015/10/21 16:55:56, Lei Zhang wrote:
> no trailing blank line

Done.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:68: const CPDF_String*
pString = AsString();
On 2015/10/21 16:55:56, Lei Zhang wrote:
> Maybe do AsString()->m_String here, instead of twice on the next 2 lines.

Done.

Good catch, missed the m_String duplication.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:338: 
On 2015/10/21 16:55:56, Lei Zhang wrote:
> no blank line

Done.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_action...
File core/src/fpdfdoc/doc_action.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_action...
core/src/fpdfdoc/doc_action.cpp:136: 
On 2015/10/21 16:55:56, Lei Zhang wrote:
> no blank line

Done.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_formfi...
File core/src/fpdfdoc/doc_formfield.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:430: return !pValue->GetString().IsEmpty();
On 2015/10/21 16:55:56, Lei Zhang wrote:
> This should still return 0 or 1, rather than true/false.

Done.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:537: if (pValue->GetInteger() == index)
On 2015/10/21 16:55:56, Lei Zhang wrote:
> just return pValue->GetInteger() == index;

Done.

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/formfiller/FFL_...
File fpdfsdk/src/formfiller/FFL_Utils.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/formfiller/FFL_...
fpdfsdk/src/formfiller/FFL_Utils.cpp:84: // TRACE(pObj->AsString()->GetString()
+ "\n");
On 2015/10/21 16:55:57, Lei Zhang wrote:
> This entire function just needs to go.

Acknowledged.

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/fsdk_baseform.cpp
File fpdfsdk/src/fsdk_baseform.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/fsdk_baseform.c...
fpdfsdk/src/fsdk_baseform.cpp:2233: 
On 2015/10/21 16:55:57, Lei Zhang wrote:
> no blank line

Done.

[dsinclair, 2015-10-21 17:08:30]

Committed patchset #2 (id:20001) manually as
53d3ab125ef583be8cfac907b308a6551b93067a (presubmit successful).

[Tom Sepez, 2015-10-21 17:12:51]

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:1360: int n =
pArray->GetCount(), nsegs = 0, i;
nit: one per line, also make i local to |for (int i ...)|

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:179: AsString()->m_String =
str;
nit: pity we don't have a SetString method as for numbers.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:216: return
AsString()->Identical(pOther->AsString());
Ok, I guess we checked for null above.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp:377: FX_BOOL bHex =
pObj->AsString()->IsHex();
nit: local(s) not needed.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_formfi...
File core/src/fpdfdoc/doc_formfield.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:532: return (pValue->GetUnicodeText() ==
opt_value);
nit: overparenthesized.

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/javascript/Docu...
File fpdfsdk/src/javascript/Document.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/javascript/Docu...
fpdfsdk/src/javascript/Document.cpp:856: if (pValueObj->IsNumber()) {
nit: probably else if since it can't be both a number and a string at the same
time.

[dsinclair, 2015-10-21 17:40:01]

Made fixes in name type-cast Cl.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp:1360: int n =
pArray->GetCount(), nsegs = 0, i;
On 2015/10/21 17:12:50, Tom Sepez wrote:
> nit: one per line, also make i local to |for (int i ...)|

Done.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:179: AsString()->m_String =
str;
On 2015/10/21 17:12:50, Tom Sepez wrote:
> nit: pity we don't have a SetString method as for numbers.

https://code.google.com/p/pdfium/issues/detail?id=240

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp:377: FX_BOOL bHex =
pObj->AsString()->IsHex();
On 2015/10/21 17:12:50, Tom Sepez wrote:
> nit: local(s) not needed.

Done.

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_formfi...
File core/src/fpdfdoc/doc_formfield.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:532: return (pValue->GetUnicodeText() ==
opt_value);
On 2015/10/21 17:12:50, Tom Sepez wrote:
> nit: overparenthesized.

Done.

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/javascript/Docu...
File fpdfsdk/src/javascript/Document.cpp (right):

https://codereview.chromium.org/1417933002/diff/1/fpdfsdk/src/javascript/Docu...
fpdfsdk/src/javascript/Document.cpp:856: if (pValueObj->IsNumber()) {
On 2015/10/21 17:12:50, Tom Sepez wrote:
> nit: probably else if since it can't be both a number and a string at the same
> time.

Done.