Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 141793002: Allow determining if an SVG value has been specified (Closed)

Created:
6 years, 11 months ago by fs
Modified:
6 years, 11 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, dstockwell, Timothy Loh, krit, f(malita), darktears, pdr, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Allow determining if an SVG value has been specified When checking for the "presence" of a value (if a value has been specified - either via an attribute or via an animation), using hasAttribute is not sufficient since if misses if the value is being animated. Extend the property interfaces to allow providing an answer to this query. R=kouhei@chromium.org TEST=svg/animations/no-attr-*.svg BUG=330191 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165537

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -5 lines) Patch
A LayoutTests/svg/animations/no-attr-lineargradient-gradienttransform.svg View 1 chunk +9 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-lineargradient-gradienttransform-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-lineargradient-gradientunits.svg View 1 chunk +9 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-lineargradient-gradientunits-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-lineargradient-spreadmethod.svg View 1 chunk +11 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-lineargradient-spreadmethod-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-lineargradient-x1.svg View 1 chunk +9 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-lineargradient-x1-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-lineargradient-x2.svg View 1 chunk +9 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-lineargradient-x2-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-lineargradient-y1.svg View 1 chunk +9 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-lineargradient-y1-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-lineargradient-y2.svg View 1 chunk +9 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-lineargradient-y2-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-pattern-height.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-pattern-height-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-pattern-par.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-pattern-par-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-pattern-patterncontentunits.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-pattern-patterncontentunits-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-pattern-patterntransform.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-pattern-patterntransform-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-pattern-patternunits.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-pattern-patternunits-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-pattern-viewbox.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-pattern-viewbox-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-pattern-width.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-pattern-width-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-pattern-x.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-pattern-x-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-pattern-y.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-pattern-y-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-cx.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-radialgradient-cx-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-cy.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-radialgradient-cy-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-fr.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-fr-expected.svg View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-fx.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-fx-expected.svg View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-fy.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-fy-expected.svg View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-gradienttransform.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-radialgradient-gradienttransform-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-gradientunits.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-radialgradient-gradientunits-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-r.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A + LayoutTests/svg/animations/no-attr-radialgradient-r-expected.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-spreadmethod.svg View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/no-attr-radialgradient-spreadmethod-expected.svg View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/svg/SVGPatternElement.cpp View 1 2 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/properties/NewSVGAnimatedProperty.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/svg/properties/NewSVGAnimatedProperty.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/svg/properties/SVGAnimatedPropertyMacros.h View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
fs
6 years, 11 months ago (2014-01-17 16:40:14 UTC) #1
kouhei (in TOK)
lgtm
6 years, 11 months ago (2014-01-17 18:30:47 UTC) #2
fs
Turbulence encountered. Rebase w/ conflicts addressed.
6 years, 11 months ago (2014-01-20 09:56:29 UTC) #3
pdr.
On 2014/01/20 09:56:29, fs wrote: > Turbulence encountered. Rebase w/ conflicts addressed. LGTM2
6 years, 11 months ago (2014-01-21 19:37:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141793002/110001
6 years, 11 months ago (2014-01-21 19:37:35 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/svg/SVGPatternElement.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-21 19:38:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141793002/260001
6 years, 11 months ago (2014-01-22 09:17:00 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8570
6 years, 11 months ago (2014-01-22 11:44:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141793002/260001
6 years, 11 months ago (2014-01-22 12:55:23 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8617
6 years, 11 months ago (2014-01-22 16:17:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/141793002/260001
6 years, 11 months ago (2014-01-22 16:27:14 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 17:31:24 UTC) #12
Message was sent while issue was closed.
Change committed as 165537

Powered by Google App Engine
This is Rietveld 408576698