Allow determining if an SVG value has been specified

Allow determining if an SVG value has been specified

When checking for the "presence" of a value (if a value has been
specified - either via an attribute or via an animation), using
hasAttribute is not sufficient since if misses if the value is being
animated.

Extend the property interfaces to allow providing an answer to this query.

R=kouhei@chromium.org
TEST=svg/animations/no-attr-*.svg
BUG=330191
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165537

[kouhei (in TOK), 2014-01-17 18:30:47]

lgtm

[fs, 2014-01-20 09:56:29]

Turbulence encountered. Rebase w/ conflicts addressed.

[pdr., 2014-01-21 19:37:16]

On 2014/01/20 09:56:29, fs wrote:
> Turbulence encountered. Rebase w/ conflicts addressed.

LGTM2

[commit-bot: I haz the power, 2014-01-21 19:37:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/141793002/110001

[commit-bot: I haz the power, 2014-01-21 19:38:09]

Failed to apply patch for Source/core/svg/SVGPatternElement.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/svg/SVGPatternElement.cpp
  Hunk #1 FAILED at 172.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/svg/SVGPatternElement.cpp.rej

Patch:       Source/core/svg/SVGPatternElement.cpp
Index: Source/core/svg/SVGPatternElement.cpp
diff --git a/Source/core/svg/SVGPatternElement.cpp
b/Source/core/svg/SVGPatternElement.cpp
index
d54cf96a043896603070ad34d5e7789f64f42d45..5d56f4dd37efba01f6116f4a87ebbeaa15ba8dce
100644
--- a/Source/core/svg/SVGPatternElement.cpp
+++ b/Source/core/svg/SVGPatternElement.cpp
@@ -172,31 +172,31 @@ void
SVGPatternElement::collectPatternAttributes(PatternAttributes& attributes)
 
     const SVGPatternElement* current = this;
     while (current) {
-        if (!attributes.hasX() && current->hasAttribute(SVGNames::xAttr))
+        if (!attributes.hasX() && current->x()->isSpecified())
             attributes.setX(current->x()->currentValue());
 
-        if (!attributes.hasY() && current->hasAttribute(SVGNames::yAttr))
+        if (!attributes.hasY() && current->y()->isSpecified())
             attributes.setY(current->y()->currentValue());
 
-        if (!attributes.hasWidth() &&
current->hasAttribute(SVGNames::widthAttr))
+        if (!attributes.hasWidth() && current->width()->isSpecified())
             attributes.setWidth(current->width()->currentValue());
 
-        if (!attributes.hasHeight() &&
current->hasAttribute(SVGNames::heightAttr))
+        if (!attributes.hasHeight() && current->height()->isSpecified())
             attributes.setHeight(current->height()->currentValue());
 
-        if (!attributes.hasViewBox() &&
current->hasAttribute(SVGNames::viewBoxAttr) &&
current->viewBox()->currentValue()->isValid())
+        if (!attributes.hasViewBox() && current->viewBox()->isSpecified() &&
current->viewBox()->currentValue()->isValid())
             attributes.setViewBox(current->viewBox()->currentValue()->value());
 
-        if (!attributes.hasPreserveAspectRatio() &&
current->hasAttribute(SVGNames::preserveAspectRatioAttr))
+        if (!attributes.hasPreserveAspectRatio() &&
current->preserveAspectRatioSpecified())
            
attributes.setPreserveAspectRatio(current->preserveAspectRatioCurrentValue());
 
-        if (!attributes.hasPatternUnits() &&
current->hasAttribute(SVGNames::patternUnitsAttr))
+        if (!attributes.hasPatternUnits() && current->patternUnitsSpecified())
             attributes.setPatternUnits(current->patternUnitsCurrentValue());
 
-        if (!attributes.hasPatternContentUnits() &&
current->hasAttribute(SVGNames::patternContentUnitsAttr))
+        if (!attributes.hasPatternContentUnits() &&
current->patternContentUnitsSpecified())
            
attributes.setPatternContentUnits(current->patternContentUnitsCurrentValue());
 
-        if (!attributes.hasPatternTransform() &&
current->hasAttribute(SVGNames::patternTransformAttr)) {
+        if (!attributes.hasPatternTransform() &&
current->patternTransformSpecified()) {
             AffineTransform transform;
             current->patternTransformCurrentValue().concatenate(transform);
             attributes.setPatternTransform(transform);

[commit-bot: I haz the power, 2014-01-22 09:17:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/141793002/260001

[commit-bot: I haz the power, 2014-01-22 11:44:19]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-22 12:55:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/141793002/260001

[commit-bot: I haz the power, 2014-01-22 16:17:49]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2014-01-22 16:27:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/141793002/260001

[commit-bot: I haz the power, 2014-01-22 17:31:24]

Change committed as 165537