Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1417923005: Revert of Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and trybot. (Closed)

Created:
5 years, 1 month ago by Georges Khalil
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and trybot. (patchset #1 id:100001 of https://codereview.chromium.org/1423733003/ ) Reason for revert: This seems to break the Mac Builder. Output is here: https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/30992 Original issue's description: > Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and trybot. > > BUG=507796 > > Committed: https://crrev.com/78fe10dde5b14fa699a8195ba050efc9c5204958 > Cr-Commit-Position: refs/heads/master@{#356573} TBR=phajdan.jr@chromium.org,maruel@chromium.org,kbr@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507796 Committed: https://crrev.com/8fd1011e2aa9a68766a053861c43be04fafa15ac Cr-Commit-Position: refs/heads/master@{#356602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -123 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/telemetry_perf_unittests.isolate View 1 chunk +0 lines, -26 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 7 chunks +28 lines, -28 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +20 lines, -20 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +16 lines, -16 lines 0 comments Download
D tools/perf/perf.isolate View 1 chunk +0 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry.isolate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Georges Khalil
Created Revert of Run telemetry_perf_unittests via isolate on "Windows Tests" & "Mac tests" and trybot.
5 years, 1 month ago (2015-10-28 19:08:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417923005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417923005/1
5 years, 1 month ago (2015-10-28 19:09:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 19:10:24 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 19:11:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fd1011e2aa9a68766a053861c43be04fafa15ac
Cr-Commit-Position: refs/heads/master@{#356602}

Powered by Google App Engine
This is Rietveld 408576698