Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1417913004: gpu: don't use Texture::ValidForTexture() for GL Image. (Closed)

Created:
5 years, 1 month ago by dshwang
Modified:
5 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: don't use Texture::ValidForTexture() for GL Image. GLES2DecoderImpl::DoCopySubTextureCHROMIUM/DoCompressedCopySubTextureCHROMIUM uses ValidForTexture to check dimensions of source texture. If the source texture is backed by GL Image, the decoder can report false positive error. TEST=video texture test on webgl_conformance BUG=517548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dshwang
piman, could you review? It's fixed as part of cube map CL in https://codereview.chromium.org/1275773003/diff/80001/gpu/command_buffer/service/gles2_cmd_decoder.cc#oldcode12509, but ...
5 years, 1 month ago (2015-10-28 18:52:55 UTC) #4
Ken Russell (switch to Gerrit)
I think it would be better to fold this into patch set 2 of https://codereview.chromium.org/1413833006/ ...
5 years, 1 month ago (2015-10-28 22:29:00 UTC) #5
Ken Russell (switch to Gerrit)
+zmo as reviewer too, just in case.
5 years, 1 month ago (2015-10-28 22:30:56 UTC) #7
dshwang
5 years, 1 month ago (2015-10-29 09:12:47 UTC) #8
On 2015/10/28 22:30:56, Ken Russell wrote:
> +zmo as reviewer too, just in case.

thank you for guidance. I fold this cl into
https://codereview.chromium.org/1413833006/
close as duplicated.

Powered by Google App Engine
This is Rietveld 408576698