third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html - Issue 1417913002: Notifications: Improve SW notification property layout test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html

Issue 1417913002: Notifications: Improve SW notification property layout test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review nits Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html b/third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html

index cddb8d0ea27b9e7b3ed345a01a268564961e2256..90b5b9eaf8608f752df513be3ba502d6cd53b749 100644

--- a/third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html

+++ b/third_party/WebKit/LayoutTests/http/tests/notifications/notification-properties.html

@@ -12,6 +12,9 @@

// manually, grant Notification permission first.

test(function () {

assert_greater_than_equal(Notification.maxActions, 0);

+ var oldMaxActions = Notification.maxActions;

+ Notification.maxActions++;

+ assert_equals(Notification.maxActions, oldMaxActions, 'Notification.maxActions should be immutable.');

var options = {

dir: "rtl",

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html » ('j') | no next file with comments »