Componentize ProfileMetrics::Counts

Componentize ProfileMetrics::Counts

ProfileMetrics::Counts and related histograms are used by all platforms
including iOS, and it is important that iOS remains consistent with the
other platforms.
This CL componentizes these metrics to be able to share them cleanly on
iOS.

TBR=jochen

Committed: https://crrev.com/78da6543bfa311596260e7dc1cde051286d751f9
Cr-Commit-Position: refs/heads/master@{#357333}

[droger, 2015-10-30 14:19:58]

droger@chromium.org changed reviewers:
+ anthonyvd@chromium.org, blundell@chromium.org

[droger, 2015-10-30 14:19:58]

anthonyvd: for review
rogerta: CC
blundell: as OWNER for components

[anthonyvd, 2015-10-30 16:13:05]

lgtm % a question

This makes perfect sense. We're also planning some other metrics consolidation
across platforms for signin and profiles that will put other metrics in
components so thanks for this!

https://codereview.chromium.org/1417903006/diff/40001/components/profile_metr...
File components/profile_metrics.gypi (left):

https://codereview.chromium.org/1417903006/diff/40001/components/profile_metr...
components/profile_metrics.gypi:20: 'toolbar/toolbar_model.cc',
Not sure I understand this toolbar stuff being removed? Weird rebase?

[droger, 2015-10-30 17:05:04]

https://codereview.chromium.org/1417903006/diff/40001/components/profile_metr...
File components/profile_metrics.gypi (left):

https://codereview.chromium.org/1417903006/diff/40001/components/profile_metr...
components/profile_metrics.gypi:20: 'toolbar/toolbar_model.cc',
On 2015/10/30 16:13:04, anthonyvd wrote:
> Not sure I understand this toolbar stuff being removed? Weird rebase?

This is actually a new file. The code review tool shows it as a modified file,
but it is a lie.
I'm creating the component from scratch.

[droger, 2015-10-30 17:20:52]

I re-uploaded a new patch using the --no-find-copies option and the files now
correctly show as new.

I also added a OWNERS file.

[blundell, 2015-11-02 08:50:11]

lgtm

This is great, thanks David!

[droger, 2015-11-02 10:35:10]

The CQ bit was checked by droger@chromium.org

[droger, 2015-11-02 10:35:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/1417903006/#ps60001
(title: "Add owners and fix Windows compile")

[commit-bot: I haz the power, 2015-11-02 10:35:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417903006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417903006/60001

[commit-bot: I haz the power, 2015-11-02 10:43:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-02 10:43:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[droger, 2015-11-02 10:49:59]

Description was changed from

==========
Componentize ProfileMetrics::Counts

ProfileMetrics::Counts and related histograms are used by all platforms
including iOS, and it is important that iOS remains consistent with the
other platforms.
This CL componentizes these metrics to be able to share them cleanly on
iOS.
==========

to

==========
Componentize ProfileMetrics::Counts

ProfileMetrics::Counts and related histograms are used by all platforms
including iOS, and it is important that iOS remains consistent with the
other platforms.
This CL componentizes these metrics to be able to share them cleanly on
iOS.

TBR=jochen
==========

[droger, 2015-11-02 10:50:59]

droger@chromium.org changed reviewers:
+ jochen@chromium.org

[droger, 2015-11-02 10:51:00]

TBR=jochen for trivial changes to
//chrome/browser/DEPS
//chrome/browser/BUILD.gn
(this is simply adding a dependency to the new component).

[droger, 2015-11-02 10:51:09]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2015-11-02 10:51:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417903006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417903006/60001

[commit-bot: I haz the power, 2015-11-02 11:26:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-02 11:27:09]

Patchset 4 (id:??) landed as
https://crrev.com/78da6543bfa311596260e7dc1cde051286d751f9
Cr-Commit-Position: refs/heads/master@{#357333}