Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: cc/playback/display_item_list.cc

Issue 1417903005: Revert of Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/resources/texture_mailbox.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/display_item_list.cc
diff --git a/cc/playback/display_item_list.cc b/cc/playback/display_item_list.cc
index 40194f748e883a3d3b30c26ac66bd20de012cfb8..7614bfd8a2fc81a5fcaf2e783e98b5572f05e13e 100644
--- a/cc/playback/display_item_list.cc
+++ b/cc/playback/display_item_list.cc
@@ -203,7 +203,7 @@
if (use_cached_picture_ && retain_individual_display_items_)
return 0;
- DCHECK(!use_cached_picture_ || picture_);
+ DCHECK_IMPLIES(use_cached_picture_, picture_);
size_t memory_usage = sizeof(*this);
@@ -273,7 +273,7 @@
DCHECK(ProcessAppendedItemsCalled());
// This should be only called once, and only after CreateAndCacheSkPicture.
DCHECK(image_map_.empty());
- DCHECK(!use_cached_picture_ || picture_);
+ DCHECK_IMPLIES(use_cached_picture_, picture_);
if (use_cached_picture_ && !picture_->willPlayBackBitmaps())
return;
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/resources/texture_mailbox.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698