Shouldn't access LayerTreeTest::layer_tree_host on impl thread

Shouldn't access LayerTreeTest::layer_tree_host on impl thread

If the main thread is unblocked and we access this function on the impl thread,
we're in a racy situation. This should be an error.

BUG=235188
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202942

[danakj, 2013-04-25 20:56:57]

LGTM, thanks!

https://codereview.chromium.org/14179022/diff/1/cc/trees/single_thread_proxy.cc
File cc/trees/single_thread_proxy.cc (right):

https://codereview.chromium.org/14179022/diff/1/cc/trees/single_thread_proxy....
cc/trees/single_thread_proxy.cc:186:
DebugScopedSetImplThreadAndMainThreadBlocked impl_and_main_blocked(this);
nit: s/and/with/ (theyre not both blocked)

[commit-bot: I haz the power, 2013-04-26 00:54:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/14179022/3001

[commit-bot: I haz the power, 2013-04-26 00:57:55]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-25 13:24:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/14179022/3001

[commit-bot: I haz the power, 2013-05-25 13:24:58]

Failed to apply patch for cc/test/layer_tree_test.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file cc/test/layer_tree_test.h
  Hunk #1 FAILED at 145.
  1 out of 1 hunk FAILED -- saving rejects to file cc/test/layer_tree_test.h.rej

Patch:       cc/test/layer_tree_test.h
Index: cc/test/layer_tree_test.h
diff --git a/cc/test/layer_tree_test.h b/cc/test/layer_tree_test.h
index
c1a4b670965528dba8d005c5bb400f55e3b55722..0a4053548df17c151e541ee6fb88d553eba222dc
100644
--- a/cc/test/layer_tree_test.h
+++ b/cc/test/layer_tree_test.h
@@ -145,7 +145,7 @@ class LayerTreeTest : public testing::Test, public TestHooks
{
 
   bool TestEnded() const { return ended_; }
 
-  LayerTreeHost* layer_tree_host() { return layer_tree_host_.get(); }
+  LayerTreeHost* layer_tree_host();
 
  private:
   LayerTreeSettings settings_;

[danakj, 2013-05-29 11:32:10]

Looks like this just needs a rebase.

[commit-bot: I haz the power, 2013-05-29 17:23:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/14179022/17001

[commit-bot: I haz the power, 2013-05-29 19:45:35]

Change committed as 202942