Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: runtime/vm/assembler_ia32.cc

Issue 14179015: - Remove heap tracing. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_ia32.h ('k') | runtime/vm/class_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.cc
===================================================================
--- runtime/vm/assembler_ia32.cc (revision 21785)
+++ runtime/vm/assembler_ia32.cc (working copy)
@@ -8,7 +8,6 @@
#include "vm/assembler.h"
#include "vm/code_generator.h"
#include "vm/heap.h"
-#include "vm/heap_trace.h"
#include "vm/memory_region.h"
#include "vm/runtime_entry.h"
#include "vm/stub_code.h"
@@ -1911,7 +1910,6 @@
Register value,
bool can_value_be_smi) {
ASSERT(object != value);
- TraceStoreIntoObject(object, dest, value);
movl(dest, value);
Label done;
if (can_value_be_smi) {
@@ -1933,7 +1931,6 @@
void Assembler::StoreIntoObjectNoBarrier(Register object,
const Address& dest,
Register value) {
- TraceStoreIntoObject(object, dest, value);
movl(dest, value);
#if defined(DEBUG)
Label done;
@@ -1953,7 +1950,6 @@
if (value.IsSmi() || value.InVMHeap()) {
movl(dest, Immediate(reinterpret_cast<int32_t>(value.raw())));
} else {
- // No heap trace for an old object store.
ASSERT(value.IsOld());
AssemblerBuffer::EnsureCapacity ensured(&buffer_);
EmitUint8(0xC7);
@@ -1964,23 +1960,6 @@
}
-void Assembler::TraceStoreIntoObject(Register object,
- const Address& dest,
- Register value) {
- if (HeapTrace::is_enabled()) {
- pushal();
- EnterCallRuntimeFrame(3 * kWordSize);
- movl(Address(ESP, 0 * kWordSize), object);
- leal(EAX, dest);
- movl(Address(ESP, 1 * kWordSize), EAX);
- movl(Address(ESP, 2 * kWordSize), value);
- CallRuntime(kHeapTraceStoreRuntimeEntry);
- LeaveCallRuntimeFrame();
- popal();
- }
-}
-
-
void Assembler::LoadDoubleConstant(XmmRegister dst, double value) {
// TODO(5410843): Need to have a code constants table.
int64_t constant = bit_cast<int64_t, double>(value);
« no previous file with comments | « runtime/vm/assembler_ia32.h ('k') | runtime/vm/class_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698