Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: Source/bindings/derived_sources.gyp

Issue 14179013: Add support for [NoInterfaceObject] extended attribute to bindings generator (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Applied Kentaro's comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/derived_sources.gyp
diff --git a/Source/bindings/derived_sources.gyp b/Source/bindings/derived_sources.gyp
index 5b99c451b30a58599eeaa9551cd610fcfaa68bfc..19599f9ee6eb3c8586edb0d3be9750283d748780 100644
--- a/Source/bindings/derived_sources.gyp
+++ b/Source/bindings/derived_sources.gyp
@@ -85,8 +85,34 @@
'optimize': 'max',
},
},
-
+ # Touch DOMWindow.idl if any IDL file has changed so that DOMWindow attributes
+ # are properly generated to each interface that does not have NoInterfaceObject
+ # extended attribute set.
'targets': [{
+ 'target_name': 'touch_domwindow',
+ 'type': 'none',
+ 'actions': [{
+ 'action_name': 'touchDOMWindow',
+ 'variables': {
+ # Write sources into a file, so that the action command line won't
+ # exceed OS limits.
+ 'idl_files_list': '<|(idl_files_list.tmp <@(idl_files))',
do-not-use 2013/04/22 15:39:11 I would need to get rid of DOMWindow.idl in idl_fi
do-not-use 2013/04/22 15:47:20 I tried the following: http://pastebin.com/kJs4aAT
+ },
+ 'inputs': [
+ '<(idl_files_list)',
+ '<!@(cat <(idl_files_list))',
+ ],
+ 'outputs': [
+ '../core/page/DOMWindow.idl',
+ ],
+ 'action': [
+ 'touch',
+ '../core/page/DOMWindow.idl',
+ ],
+ 'message': 'Touching DOMWindow.idl',
+ }]
+ },
+ {
'target_name': 'supplemental_dependencies',
'type': 'none',
'actions': [{
@@ -126,6 +152,7 @@
'type': 'none',
'hard_dependency': 1,
'dependencies': [
+ 'touch_domwindow',
'supplemental_dependencies',
'../core/core.gyp/core_derived_sources.gyp:generate_settings',
],

Powered by Google App Engine
This is Rietveld 408576698