Source/bindings/scripts/IDLParser.pm - Issue 14179013: Add support for [NoInterfaceObject] extended attribute to bindings generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/IDLParser.pm

Issue 14179013: Add support for [NoInterfaceObject] extended attribute to bindings generator (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take Adam's feedback into consideration Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/IDLParser.pm

diff --git a/Source/bindings/scripts/IDLParser.pm b/Source/bindings/scripts/IDLParser.pm

index aaf86501840d24c489d040e5ec273dabd531d236..1c3c531eaa14aa77d4bc055c6970c112c59b9fd2 100644

--- a/Source/bindings/scripts/IDLParser.pm

+++ b/Source/bindings/scripts/IDLParser.pm

@@ -832,7 +832,7 @@ sub parseTypedef

$self->assertTokenType($nameToken, IdentifierToken);

$self->assertTokenValue($self->getToken(), ";", __LINE__);

my $name = $nameToken->value();

- die "typedef redefinition for " . $name . " at " . $self->{Line} if exists $typedefs{$name};

+ die "typedef redefinition for " . $name . " at " . $self->{Line} if (exists $typedefs{$name} && $typedef->type ne $typedefs{$name}->type);

$typedefs{$name} = $typedef;

return;

}

« no previous file with comments | « Source/bindings/scripts/IDLAttributes.txt ('k') | Source/bindings/scripts/preprocess-idls.pl » ('j') | Source/bindings/scripts/preprocess-idls.pl » ('J')