Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 14179013: Add support for [NoInterfaceObject] extended attribute to bindings generator (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Faster processing of DOMWindow.idl + Handling of Callback interfaces Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/CodeGeneratorV8.pm
diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm
index ba38bb6987608368159bb8aa9ef736af889ee1b9..ea1dc371c1b12b31326fec4ea10909028b286319 100644
--- a/Source/bindings/scripts/CodeGeneratorV8.pm
+++ b/Source/bindings/scripts/CodeGeneratorV8.pm
@@ -3263,6 +3263,15 @@ END
push(@normalAttributes, $attribute);
}
}
+
+ # Generate DOMWindow Constructor attributes.
+ if ($interfaceName eq "DOMWindow") {
+ my ($generatedNormalAttributes, $generatedEnabledAtRuntimeAttributes, $generatedEnabledPerContextAttributes) = $codeGenerator->GenerateDOMWindowConstructorAttributes();
+ @normalAttributes = (@normalAttributes, @$generatedNormalAttributes);
+ @enabledAtRuntimeAttributes = (@enabledAtRuntimeAttributes, @$generatedEnabledAtRuntimeAttributes);
+ @enabledPerContextAttributes = (@enabledPerContextAttributes, @$generatedEnabledPerContextAttributes);
+ }
+
$attributes = \@normalAttributes;
# Put the attributes that disallow shadowing on the shadow object.
if (@disallowsShadowing) {

Powered by Google App Engine
This is Rietveld 408576698