Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: chrome/browser/chromeos/login/parallel_authenticator_unittest.cc

Issue 14179007: Move cryptohome_library to src/chromeos (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/parallel_authenticator_unittest.cc
diff --git a/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc b/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc
index 894b9790284d5885c39f703d3609a983a310edf0..80ee5e32de761934edd87e137a1e74a7e0475412 100644
--- a/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc
+++ b/chrome/browser/chromeos/login/parallel_authenticator_unittest.cc
@@ -14,7 +14,6 @@
#include "base/stringprintf.h"
#include "chrome/browser/chromeos/cros/cros_library.h"
#include "chrome/browser/chromeos/cros/mock_cert_library.h"
-#include "chrome/browser/chromeos/cros/mock_cryptohome_library.h"
#include "chrome/browser/chromeos/login/mock_login_status_consumer.h"
#include "chrome/browser/chromeos/login/mock_url_fetchers.h"
#include "chrome/browser/chromeos/login/mock_user_manager.h"
@@ -26,6 +25,7 @@
#include "chrome/browser/chromeos/settings/stub_cros_settings_provider.h"
#include "chrome/test/base/testing_profile.h"
#include "chromeos/cryptohome/mock_async_method_caller.h"
+#include "chromeos/cryptohome/mock_cryptohome_library.h"
#include "chromeos/dbus/mock_cryptohome_client.h"
#include "chromeos/dbus/mock_dbus_thread_manager.h"
#include "content/public/test/test_browser_thread.h"
@@ -80,8 +80,8 @@ class ParallelAuthenticatorTest : public testing::Test {
chromeos::CrosLibrary::TestApi* test_api =
chromeos::CrosLibrary::Get()->GetTestApi();
- mock_cryptohome_library_ = new MockCryptohomeLibrary();
- test_api->SetCryptohomeLibrary(mock_cryptohome_library_, true);
+ mock_cryptohome_library_ .reset(new MockCryptohomeLibrary());
+ CryptohomeLibrary::SetForTest(mock_cryptohome_library_.get());
mock_cert_library_ = new MockCertLibrary();
EXPECT_CALL(*mock_cert_library_, LoadKeyStore()).Times(AnyNumber());
@@ -103,10 +103,7 @@ class ParallelAuthenticatorTest : public testing::Test {
// Tears down the test fixture.
virtual void TearDown() {
- // Prevent bogus gMock leak check from firing.
- chromeos::CrosLibrary::TestApi* test_api =
- chromeos::CrosLibrary::Get()->GetTestApi();
- test_api->SetCryptohomeLibrary(NULL, false);
+ CryptohomeLibrary::SetForTest(NULL);
cryptohome::AsyncMethodCaller::Shutdown();
mock_caller_ = NULL;
@@ -226,10 +223,10 @@ class ParallelAuthenticatorTest : public testing::Test {
// Mocks, destroyed by CrosLibrary class.
MockCertLibrary* mock_cert_library_;
- MockCryptohomeLibrary* mock_cryptohome_library_;
-
ScopedUserManagerEnabler user_manager_enabler_;
+ scoped_ptr<MockCryptohomeLibrary> mock_cryptohome_library_;
+
cryptohome::MockAsyncMethodCaller* mock_caller_;
MockConsumer consumer_;

Powered by Google App Engine
This is Rietveld 408576698