Move cryptohome_library to src/chromeos

Move cryptohome_library to src/chromeos

This CL does the following:
1. Move [De|En]cryptWithSystemSalt to CryptohomeLibrary
2. Remove CryptohomeLibrary from CrosLibrary
3. Move CryptohomeLibrary to src/chromeos

BUG=233724
For chrome_browser_chromeos.gypi
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196159

[satorux1, 2013-04-22 01:00:07]

LGTM

[hashimoto, 2013-04-22 06:59:49]

lgtm assuming all tests will pass after the compile error is fixed.

https://codereview.chromium.org/14179007/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/login_browsertest.cc (right):

https://codereview.chromium.org/14179007/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/login_browsertest.cc:24: #include
"chromeos/cryptohome/mock_network_library.h"
This line seems not compiling.

[Mattias Nissler (ping if slow), 2013-04-22 09:43:40]

chrome/browser/{policy,settings} LGTM

https://codereview.chromium.org/14179007/diff/1/chromeos/cryptohome/cryptohom...
File chromeos/cryptohome/cryptohome_library.h (right):

https://codereview.chromium.org/14179007/diff/1/chromeos/cryptohome/cryptohom...
chromeos/cryptohome/cryptohome_library.h:26: // implementation). Call
SetForTest(NUL) when |impl| is deleted.
NULL

https://codereview.chromium.org/14179007/diff/1/chromeos/cryptohome/cryptohom...
chromeos/cryptohome/cryptohome_library.h:29: // Returns a CryptohomeLibrary
instace for testing. Does not set or affect
instance

[stevenjb, 2013-04-22 16:54:30]

https://codereview.chromium.org/14179007/diff/1/chromeos/cryptohome/cryptohom...
File chromeos/cryptohome/cryptohome_library.h (right):

https://codereview.chromium.org/14179007/diff/1/chromeos/cryptohome/cryptohom...
chromeos/cryptohome/cryptohome_library.h:26: // implementation). Call
SetForTest(NUL) when |impl| is deleted.
On 2013/04/22 09:43:40, Mattias Nissler wrote:
> NULL

Done.

https://codereview.chromium.org/14179007/diff/1/chromeos/cryptohome/cryptohom...
chromeos/cryptohome/cryptohome_library.h:29: // Returns a CryptohomeLibrary
instace for testing. Does not set or affect
On 2013/04/22 09:43:40, Mattias Nissler wrote:
> instance

Done.

[commit-bot: I haz the power, 2013-04-23 17:13:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/14179007/21001

[commit-bot: I haz the power, 2013-04-23 17:13:47]

Failed to apply patch for
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
  Hunk #1 FAILED at 10.
  1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc.rej

Patch:      
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
Index:
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
diff --git
a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
index
240030a7374d363ca6dcfcd3cb3c5d2b440484f7..adb372e7c92402dc594ae0f8fc62af8d0ba47aa7
100644
---
a/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
+++
b/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
@@ -10,7 +10,6 @@
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/run_loop.h"
-#include "chrome/browser/chromeos/cros/cryptohome_library.h"
 #include "chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.h"
 #include "chrome/browser/chromeos/policy/enterprise_install_attributes.h"
 #include "chrome/browser/chromeos/policy/proto/chrome_device_policy.pb.h"
@@ -20,6 +19,7 @@
 #include "chrome/browser/policy/cloud/mock_device_management_service.h"
 #include "chrome/browser/policy/cloud/proto/device_management_backend.pb.h"
 #include "chrome/browser/prefs/browser_prefs.h"
+#include "chromeos/cryptohome/cryptohome_library.h"
 #include "chromeos/dbus/cryptohome_client.h"
 #include "chromeos/dbus/dbus_client_implementation_type.h"
 #include "policy/policy_constants.h"
@@ -49,7 +49,7 @@ class DeviceCloudPolicyManagerChromeOSTest
     : public chromeos::DeviceSettingsTestBase {
  protected:
   DeviceCloudPolicyManagerChromeOSTest()
-      : cryptohome_library_(chromeos::CryptohomeLibrary::GetImpl(true)),
+      : cryptohome_library_(chromeos::CryptohomeLibrary::GetTestImpl()),
         stub_cryptohome_client_(chromeos::CryptohomeClient::Create(
             chromeos::STUB_DBUS_CLIENT_IMPLEMENTATION, NULL)),
         install_attributes_(cryptohome_library_.get(),

[commit-bot: I haz the power, 2013-04-23 19:55:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/14179007/9003

[commit-bot: I haz the power, 2013-04-23 19:56:17]

Presubmit check for 14179007-9003 failed and returned exit status 1.

INFO:root:Found 39 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/policy/PRESUBMIT.py

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  chrome/browser/policy/browser_policy_connector.cc:233
    // call SetPolicyProviderForTesting() again. It is still owned by the test.

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/chrome_browser_chromeos.gypi

Presubmit checks took 3.4s to calculate.

[commit-bot: I haz the power, 2013-04-23 20:08:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/14179007/9003

[commit-bot: I haz the power, 2013-04-23 23:14:14]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[stevenjb, 2013-04-24 16:11:38]

Committed patchset #7 manually as r196159 (presubmit successful).

[Ryan Sleevi, 2013-04-26 18:38:19]

drive-by.

https://codereview.chromium.org/14179007/diff/42001/chromeos/cryptohome/crypt...
File chromeos/cryptohome/cryptohome_library.cc (right):

https://codereview.chromium.org/14179007/diff/42001/chromeos/cryptohome/crypt...
chromeos/cryptohome/cryptohome_library.cc:26: const size_t kKeySize = 16;
nit: This is really kNonceSize.

A bit confusing, given that kKeySize suggests its for the DeriveKeyFromPassword
(which takes a key size *in bits*), and which is hardcoded at 256 bits on line
175.

https://codereview.chromium.org/14179007/diff/42001/chromeos/cryptohome/crypt...
chromeos/cryptohome/cryptohome_library.cc:172: crypto::SymmetricKey*
PassphraseToKey(const std::string& passprhase,
typo: passprhase -> passphrase