Add type cast definitions for CPDF_Array.

Add type cast definitions for CPDF_Array.

This Cl adds ToArray, CPDF_Object::AsArray and CPDF_Object::IsArray and
updates the src to use them as needed.

BUG=pdfium:201
R=thestig@chromium.org, tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/c2bfc000e502c42c9a3017038fd9104c7997d126

[dsinclair, 2015-10-21 20:40:28]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2015-10-21 20:40:28]

PTAL.

[Tom Sepez, 2015-10-21 21:07:01]

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page.cpp:817: CPDF_Array *pMediaBox, *pCropBox;
nit: Move these down to where we first assign to them.

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formfi...
File core/src/fpdfdoc/doc_formfield.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:581: if (!pArray)
CPDF_Array::Create() can't fail.

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:786: if (!pOpt || !pOpt->IsArray()) {
nit: maybe !ToArray(pOpt)

[dsinclair, 2015-10-21 21:15:14]

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page.cpp:817: CPDF_Array *pMediaBox, *pCropBox;
On 2015/10/21 21:07:01, Tom Sepez wrote:
> nit: Move these down to where we first assign to them.

Done.

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formfi...
File core/src/fpdfdoc/doc_formfield.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:581: if (!pArray)
On 2015/10/21 21:07:01, Tom Sepez wrote:
> CPDF_Array::Create() can't fail.  

Done.

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:786: if (!pOpt || !pOpt->IsArray()) {
On 2015/10/21 21:07:01, Tom Sepez wrote:
> nit: maybe !ToArray(pOpt)

Done.

[Tom Sepez, 2015-10-21 21:20:48]

LGTM after fixing comment.

https://codereview.chromium.org/1417893003/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/fpdf_page.cpp (right):

https://codereview.chromium.org/1417893003/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page.cpp:818: pMediaBox =
ToArray(GetPageAttr(FX_BSTRC("MediaBox")));
Combine with previous line.

https://codereview.chromium.org/1417893003/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page.cpp:829: pCropBox =
ToArray(GetPageAttr(FX_BSTRC("CropBox")));
ditto

[Lei Zhang, 2015-10-21 21:44:09]

Still looking...

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp:122: m_nFuncs =
pArray->GetCount();
m_nFuncs = std::min(pArray->GetCount(), 4)

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formfi...
File core/src/fpdfdoc/doc_formfield.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:434: CPDF_Object* pValue =
FPDF_GetFieldAttr(m_pDict, "V");
FYI, this block is the same as the start of CPDF_FormField::CountSelectedItems()
above.

https://codereview.chromium.org/1417893003/diff/1/fpdfsdk/src/fsdk_actionhand...
File fpdfsdk/src/fsdk_actionhandler.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/fpdfsdk/src/fsdk_actionhand...
fpdfsdk/src/fsdk_actionhandler.cpp:437: ASSERT(pPDFDocument);
Don't bother keeping ones where it dereferences the same ptr on the next line.

[Lei Zhang, 2015-10-21 22:10:12]

lgtm

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formco...
File core/src/fpdfdoc/doc_formcontrol.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formco...
core/src/fpdfdoc/doc_formcontrol.cpp:88: CPDF_Object* pOpt =
FPDF_GetFieldAttr(m_pField->m_pDict, "Opt");
or just if (ToArray(FPDF_GetFieldAttr(m_pField->m_pDict, "Opt"))) ?

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_ocg.cpp
File core/src/fpdfdoc/doc_ocg.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_ocg.cp...
core/src/fpdfdoc/doc_ocg.cpp:267: if (csP == FX_BSTRC("AnyOn") && bItem)
These 4 ifs can be combined into 2;

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_tagged...
File core/src/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_tagged...
core/src/fpdfdoc/doc_tagged.cpp:179: if
(((CPDF_Reference*)pKidRef)->GetRefObjNum() != pDict->GetObjNum())
References next?

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_tagged...
core/src/fpdfdoc/doc_tagged.cpp:395: if (subindex >= (int)pArray->GetCount())
static_cast

https://codereview.chromium.org/1417893003/diff/1/fpdfsdk/src/fpdf_transformp...
File fpdfsdk/src/fpdf_transformpage.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/fpdfsdk/src/fpdf_transformp...
fpdfsdk/src/fpdf_transformpage.cpp:271: CPDF_Object* pContentObj =
Another opportunity to combine code. (With line 111)

[dsinclair, 2015-10-22 13:31:13]

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp:122: m_nFuncs =
pArray->GetCount();
On 2015/10/21 21:44:09, Lei Zhang wrote:
> m_nFuncs = std::min(pArray->GetCount(), 4)

Done.

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formco...
File core/src/fpdfdoc/doc_formcontrol.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formco...
core/src/fpdfdoc/doc_formcontrol.cpp:88: CPDF_Object* pOpt =
FPDF_GetFieldAttr(m_pField->m_pDict, "Opt");
On 2015/10/21 22:10:12, Lei Zhang wrote:
> or just if (ToArray(FPDF_GetFieldAttr(m_pField->m_pDict, "Opt"))) ?

Done.

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formfi...
File core/src/fpdfdoc/doc_formfield.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_formfi...
core/src/fpdfdoc/doc_formfield.cpp:434: CPDF_Object* pValue =
FPDF_GetFieldAttr(m_pDict, "V");
On 2015/10/21 21:44:09, Lei Zhang wrote:
> FYI, this block is the same as the start of
CPDF_FormField::CountSelectedItems()
> above.

Almost, the return values are different. I'm going to leave refactoring things
like this out to it's own cl.

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_ocg.cpp
File core/src/fpdfdoc/doc_ocg.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_ocg.cp...
core/src/fpdfdoc/doc_ocg.cpp:267: if (csP == FX_BSTRC("AnyOn") && bItem)
On 2015/10/21 22:10:12, Lei Zhang wrote:
> These 4 ifs can be combined into 2;

Done.

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_tagged...
File core/src/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_tagged...
core/src/fpdfdoc/doc_tagged.cpp:179: if
(((CPDF_Reference*)pKidRef)->GetRefObjNum() != pDict->GetObjNum())
On 2015/10/21 22:10:12, Lei Zhang wrote:
> References next?

Soon, I'm working my way though the order they're in fpdf_objects.h.

https://codereview.chromium.org/1417893003/diff/1/core/src/fpdfdoc/doc_tagged...
core/src/fpdfdoc/doc_tagged.cpp:395: if (subindex >= (int)pArray->GetCount())
On 2015/10/21 22:10:12, Lei Zhang wrote:
> static_cast

Done.

https://codereview.chromium.org/1417893003/diff/1/fpdfsdk/src/fpdf_transformp...
File fpdfsdk/src/fpdf_transformpage.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/fpdfsdk/src/fpdf_transformp...
fpdfsdk/src/fpdf_transformpage.cpp:271: CPDF_Object* pContentObj =
On 2015/10/21 22:10:12, Lei Zhang wrote:
> Another opportunity to combine code. (With line 111)

Acknowledged.

https://codereview.chromium.org/1417893003/diff/1/fpdfsdk/src/fsdk_actionhand...
File fpdfsdk/src/fsdk_actionhandler.cpp (right):

https://codereview.chromium.org/1417893003/diff/1/fpdfsdk/src/fsdk_actionhand...
fpdfsdk/src/fsdk_actionhandler.cpp:437: ASSERT(pPDFDocument);
On 2015/10/21 21:44:09, Lei Zhang wrote:
> Don't bother keeping ones where it dereferences the same ptr on the next line.

Removed the assert for pApp, left the one for pPDFDocument. We pass it into some
methods below, but it's going to be harder to track down. (We access pDocument
below, not pPDFDocument).

https://codereview.chromium.org/1417893003/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_page/fpdf_page.cpp (right):

https://codereview.chromium.org/1417893003/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page.cpp:818: pMediaBox =
ToArray(GetPageAttr(FX_BSTRC("MediaBox")));
On 2015/10/21 21:20:48, Tom Sepez wrote:
> Combine with previous line.

Done.

https://codereview.chromium.org/1417893003/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_page/fpdf_page.cpp:829: pCropBox =
ToArray(GetPageAttr(FX_BSTRC("CropBox")));
On 2015/10/21 21:20:48, Tom Sepez wrote:
> ditto

Done.

[dsinclair, 2015-10-22 13:31:49]

Committed patchset #3 (id:40001) manually as
c2bfc000e502c42c9a3017038fd9104c7997d126 (presubmit successful).