Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: perf_insights/perf_insights/map_single_trace_cmdline.html

Issue 1417883005: Enable vulcanizing perf_insights mapper Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Undo changes to vinn Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « perf_insights/perf_insights/map_single_trace.py ('k') | perf_insights/perf_insights/map_traces.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: perf_insights/perf_insights/map_single_trace_cmdline.html
diff --git a/perf_insights/perf_insights/map_single_trace_cmdline.html b/perf_insights/perf_insights/map_single_trace_cmdline.html
index 160d1a868c5dc64c6bd4fca552b4f4b5181b3361..2964f93259117d75d61f48549f649710738895c7 100644
--- a/perf_insights/perf_insights/map_single_trace_cmdline.html
+++ b/perf_insights/perf_insights/map_single_trace_cmdline.html
@@ -7,6 +7,7 @@ found in the LICENSE file.
<link rel="import" href="/perf_insights/map_single_trace.html">
<link rel="import" href="/perf_insights/value/run_info.html">
<link rel="import" href="/perf_insights/results/results.html">
+<link rel="import" href="/perf_insights/perf_insights_full_config.html">
<script>
'use strict';
@@ -16,11 +17,7 @@ tr.exportTo('pi', function() {
var FailureValue = pi.v.FailureValue;
function getMapFunctionFromMapFunctionHandle(mapFunctionHandle) {
- if (mapFunctionHandle.mapFunctionFileName !== undefined)
- return loadMapFunctionFromFileName(mapFunctionHandle.mapFunctionFileName);
-
// Find the mapper by name.
- loadHTML('/perf_insights/perf_insights_full_config.html');
var typeInfo = pi.MapFunction.findTypeInfoMatching(function(typeInfo) {
return typeInfo.constructor.name === mapFunctionHandle.mapFunctionName;
});
@@ -35,31 +32,6 @@ tr.exportTo('pi', function() {
return typeInfo.constructor;
}
- function loadMapFunctionFromFileName(mapFunctionFileName) {
- // Load the mapper.
- var allTypeInfos = pi.MapFunction.getAllRegisteredTypeInfos();
- try {
- var numTypeInfosBefore = allTypeInfos.length;
- loadHTMLFile(mapFunctionFileName, mapFunctionFileName);
- } catch (err) {
- err.name = 'MapFunctionLoadingError';
- throw err;
- }
-
- // Verify a mapFunction was defined.
- var numTypeInfosNow = allTypeInfos.length;
- if (numTypeInfosNow !== (numTypeInfosBefore + 1)) {
- var err = new Error(mapFunctionFileName +
- ' did not call defineMapFunction');
- err.name = 'MapFunctionNotDefinedError';
- throw err;
- }
-
- var mapFunction = allTypeInfos[allTypeInfos.length - 1].constructor;
- return mapFunction;
- }
-
-
function mapSingleTraceMain(args) {
if (args.length !== 4)
throw new Error('Must provide four arguments');
« no previous file with comments | « perf_insights/perf_insights/map_single_trace.py ('k') | perf_insights/perf_insights/map_traces.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698