Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1417873003: Turn on APPCACHE_USE_SIMPLE_CACHE on Android & GN to match GYP (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on APPCACHE_USE_SIMPLE_CACHE on Android & GN to match GYP BUG=510485 Committed: https://crrev.com/efafec1379d63f19270ebd61eae67e9e3f8bf288 Cr-Commit-Position: refs/heads/master@{#355631}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
pkotwicz
brettw@ can you please take a look?
5 years, 2 months ago (2015-10-21 21:48:03 UTC) #2
brettw
lgtm
5 years, 2 months ago (2015-10-22 04:54:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417873003/20001
5 years, 2 months ago (2015-10-22 16:37:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_android/builds/69558) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-10-22 16:39:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417873003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417873003/60001
5 years, 2 months ago (2015-10-22 19:49:13 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 2 months ago (2015-10-22 20:23:09 UTC) #21
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 20:24:05 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/efafec1379d63f19270ebd61eae67e9e3f8bf288
Cr-Commit-Position: refs/heads/master@{#355631}

Powered by Google App Engine
This is Rietveld 408576698