Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1417843002: Simplify mojo::internal::ArrayTraits. (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Simplify mojo::internal::ArrayTraits. Also, stop doing a whole bunch of unnecessary stuff in the move-only case (some of it was necessary to handle move-only types, pre-C++11; some of it -- like the alignment stuff -- was of rather dubious necessity and correctness). Probably it can/should be improved even more. E.g., PushBack() should be reworked (into two overloaded versions, a const T& one and a T&& one). That leaves only Clone(), which is a bit more tricky. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/745b55da533a4f73db721f4f78bcdd0070c39f5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -75 lines) Patch
M mojo/public/cpp/bindings/array.h View 8 chunks +15 lines, -17 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_internal.h View 2 chunks +8 lines, -58 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 2 months ago (2015-10-20 23:28:11 UTC) #1
viettrungluu
(It builds and the tests pass, so it must be good, right?)
5 years, 2 months ago (2015-10-20 23:28:57 UTC) #2
jamesr
https://build.chromium.org/p/tryserver.client.mojo/builders/Mojo%20Linux%20Try/builds/5891/steps/App%20tests/logs/stdio failed something, but I don't think it's related lgtm
5 years, 2 months ago (2015-10-21 00:46:17 UTC) #3
viettrungluu
5 years, 2 months ago (2015-10-21 02:06:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
745b55da533a4f73db721f4f78bcdd0070c39f5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698