core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp - Issue 1417823005: Add type cast definitions for CPDF_Name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

Issue 1417823005: Add type cast definitions for CPDF_Name. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

index 6d071f3ae065eb80252786227b3657af13c8c775..62a3c679961083ae80a42d70600753c4715710ca 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp

@@ -510,11 +510,8 @@ void CPDF_AllStates::ProcessExtGS(CPDF_Dictionary* pGS,

continue;

}

case FXBSTR_ID('T', 'R', '2', 0):

- if (pObject && pObject->GetType() != PDFOBJ_NAME) {

- pGeneralState->m_pTR = pObject;

- } else {

- pGeneralState->m_pTR = NULL;

- }

+ pGeneralState->m_pTR =

+ (pObject && !pObject->IsName()) ? pObject : nullptr;

break;

case FXBSTR_ID('B', 'M', 0, 0): {

CFX_ByteString mode;