Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: fpdfsdk/src/javascript/Document.cpp

Issue 1417823005: Add type cast definitions for CPDF_Name. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/src/fpdfdoc/doc_tagged.cpp ('K') | « fpdfsdk/src/fpdfppo.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/javascript/Document.cpp
diff --git a/fpdfsdk/src/javascript/Document.cpp b/fpdfsdk/src/javascript/Document.cpp
index 163323ad25a8e3a8bc1c4d81057eab2c905ef8b0..2d0ab096660cf3f05ba74af8f32c4bb9831923bd 100644
--- a/fpdfsdk/src/javascript/Document.cpp
+++ b/fpdfsdk/src/javascript/Document.cpp
@@ -848,8 +848,7 @@ FX_BOOL Document::info(IJS_Context* cc,
CFX_ByteString bsKey;
CPDF_Object* pValueObj = pDictionary->GetNextElement(pos, bsKey);
CFX_WideString wsKey = CFX_WideString::FromUTF8(bsKey, bsKey.GetLength());
- if ((pValueObj->GetType() == PDFOBJ_STRING) ||
- (pValueObj->GetType() == PDFOBJ_NAME))
+ if ((pValueObj->GetType() == PDFOBJ_STRING) || pValueObj->IsName())
Lei Zhang 2015/10/21 16:59:04 Isn't this just going to conflict with the string
dsinclair 2015/10/21 17:52:41 Acknowledged.
FXJS_PutObjectString(isolate, pObj, wsKey.c_str(),
pValueObj->GetUnicodeText().c_str());
if (pValueObj->IsNumber()) {
« core/src/fpdfdoc/doc_tagged.cpp ('K') | « fpdfsdk/src/fpdfppo.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698