Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1417813004: Don't try to close first-navigation tabs when showing the supervised user interstitial inside a <we… (Closed)

Created:
5 years, 2 months ago by Bernhard Bauer
Modified:
5 years, 2 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, pam+watch_chromium.org, finkm_chromiu.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't try to close first-navigation tabs when showing the supervised user interstitial inside a <webview>. A WebContents in a <webview> is under the control of the embedding page, so we can't simply close it (and there isn't a browser or tab strip for it anyway). BUG=545394 Committed: https://crrev.com/34f34c5fe939d8520e5ce59cc31e11cc4b439e75 Cr-Commit-Position: refs/heads/master@{#355300}

Patch Set 1 #

Patch Set 2 : style #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M chrome/browser/supervised_user/supervised_user_interstitial.cc View 1 2 2 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Bernhard Bauer
Please review. Thanks!
5 years, 2 months ago (2015-10-21 14:10:19 UTC) #2
Bernhard Bauer
Sorry, had to rewrite this to compile Android, and doing the check inline was getting ...
5 years, 2 months ago (2015-10-21 14:22:32 UTC) #3
Marc Treib
LGTM (Somehow, "close this tab if it has no history" is getting *way* more complicated ...
5 years, 2 months ago (2015-10-21 14:37:54 UTC) #4
Bernhard Bauer
On 2015/10/21 14:37:54, Marc Treib wrote: > LGTM > (Somehow, "close this tab if it ...
5 years, 2 months ago (2015-10-21 14:59:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417813004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417813004/40001
5 years, 2 months ago (2015-10-21 14:59:13 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-21 15:38:38 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 15:39:23 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/34f34c5fe939d8520e5ce59cc31e11cc4b439e75
Cr-Commit-Position: refs/heads/master@{#355300}

Powered by Google App Engine
This is Rietveld 408576698